Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cancelling to apollo requests #9

Merged
merged 1 commit into from
Oct 20, 2016

Conversation

jamiepinkham
Copy link
Contributor

In the current implementation, both the fetch and perform operations of ApolloClient return a Void type. However, it's important, especially in fetching data, to be able to cancel an outbound request/response if, for instance, the user leaves the screen, or any other number of reasons.

@apollo-cla
Copy link

@jamiepinkham: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@martijnwalraven
Copy link
Contributor

Thanks for the pull request, that looks great! Nice work extracting the Cancellable protocol to abstract from URLSessionTask.

There seems to be a queue for Mac builds on Travis CI, but I'll merge it as soon as the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants