-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/public interface updates #82
Feature/public interface updates #82
Conversation
…akaila/apollo-ios into feature/public-interface-updates
…into feature/public-interface-updates
I realize Objective-C has predisposed me to long descriptive names, so My concern is that we may want to add other types of caches in the future. So Apollo Android has a response cache in addition to a normalized cache for example, and they do use the |
@martijnwalraven I'm into descriptive names as well, I just figured with the existence of the Could you explain what the response cache is used for? I was under the impression that a |
@justinmakaila: The idea of a response cache is to cache individual responses as opposed to normalized records. So you don't get any of the data sharing and consistency benefits, but it might be more efficient to cache complete responses without normalizing them. On Android, a use case that came up is downloading large blobs of data in the background for example. I think the |
I'm going to close this based on a combination of @martijnwalraven's response and the lack of activity here for quite a while. We've definitely got some thinking to do about how we're handling caching, I've got a few ideas but nothing I want to put out quite yet. |
Renamed and exposed the
InMemoryCache
. It's much easier to set up mockApolloClient
instances for testing without duplicating, and also could be useful for feeding in data.