Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out session configuration for URLSession #699

Merged
merged 4 commits into from
Aug 9, 2019

Conversation

designatednerd
Copy link
Contributor

The code changes here are pretty minimal: Swapping out a URLSessionConfiguration for the actual URLSession. However, by being able to pass in a URLSession that you control the delegate of, you can more easily support a number of things:

  • Certificate pinning
  • Self-signed certificates
  • Authentication challenge responses
  • Metrics inspection

Note that this is going to be a breaking change if you were previously passing in a session configuration to the HTTPNetworkTransport - you'll need to hand that configuration to a URLSession yourself first.

@designatednerd designatednerd added this to the 0.15.0 milestone Aug 8, 2019
@designatednerd
Copy link
Contributor Author

Blergh, something is up with Travis - it's refusing to install the starwars-server locally, so all the tests dependent on local are 💣ing out. I'll have to get a look at this late tonight or tomorrow.

@designatednerd
Copy link
Contributor Author

Woot, clearing the cache did the trick. Merging!

@designatednerd designatednerd merged commit c40119b into master Aug 9, 2019
@designatednerd designatednerd deleted the add/urlsession-param branch August 9, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant