Create a protocol for public methods of Apollo client #693
Conversation
| public extension ApolloClientProtocol { | ||
|
|
||
| @discardableResult func fetch<Query: GraphQLQuery>(query: Query, cachePolicy: CachePolicy = .returnCacheDataElseFetch, context: UnsafeMutableRawPointer? = nil, queue: DispatchQueue = DispatchQueue.main, resultHandler: GraphQLResultHandler<Query.Data>? = nil) -> Cancellable { | ||
| return fetch(query: query, cachePolicy: cachePolicy, context: context, queue: queue, resultHandler: resultHandler) |
There was a problem hiding this comment.
One thing to watch out for with these default implementations is that they will override the local implementation anywhere that the client is passed as ApolloClientProtocol. This is an extremely oversimplified example of that behavior.
I would recommend removing the default implementations here and just setting the default params on the actual implementations, since it seems like the default implementations are just there to re-add the default parameters.
|
@gsabran Would love to get this in with |
|
Hey @gsabran - If I don't hear back from you by tomorrow, I'm going to take over this PR so I can get it shipped. Excellent idea! |
|
Closing in favor of #715 since there hasn't been any movement on this and I'd still like to get it out with |
|
Hi thanks a lot for taking over, and sorry for not following up at all.. I left for vacations :) |
|
Haha, yep, I figured. 'Tis August after all. Thanks for the idea! |
This is so that developers can refer to the protocol instead of the concrete type, and use dependency injection for unit testing. It doesn't break any public APIs.