Fixed issue where a field that was removed from a Record would still exist after a merge. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exist after a merge. This could happen when a value changed to `null`. This fixes a bug in the following scenario: 1. Make a query where field `x` has value `y`. The result is cached. 2. Make the same query but bypass the cache. This time the field `x` has value `null`. 3. Make the same query again but allow fetching from the cache. *Expected Result*: field `x` has value `null`. *Actual Result*: field `x` still has value `y`. The fix was to ensure that keys/fields that do not exist in a new record are removed from the old record during a merge.
|
Closing. Not only did this not pass tests but it looks like the issue I was trying to address was fixed w/ #63. |
|
@mckaskle: Good to hear the issue was fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could happen when a value changed to
null. This fixes a bug in the following scenario:xhas valuey. The result is cached.xhas valuenull.Expected Result: field
xhas valuenull.Actual Result: field
xstill has valuey.The fix was to ensure that keys/fields that do not exist in a new record are removed from the old record during a merge.