Add option to Vacuum SQLite on clearing, clean up and document SQLite public stuff #652

designatednerd · 2019-07-20T11:55:09Z

Spurred by #650, I added a workaround for that issue, and then did some cleanup and documentation of the SQLite project:

Pulled SQLiteSerialization into its own file
Pulled methods conforming to NormalizedCache protocol into an extension
Basic documentation of class and designated initializer for SQLiteNormalizedCache.

…'re accessing local or instance variables.

designatednerd · 2019-07-20T11:56:02Z

@ZevEisenberg For some reason I can't request your review on this through the "request a review" thing but would you mind taking a look at this?

Sources/ApolloSQLite/SQLiteNormalizedCache.swift

Co-Authored-By: Zev Eisenberg <zev@zeveisenberg.com>

designatednerd added 6 commits July 20, 2019 12:53

move SQLiteSerialization into its own file for clarity

b0d49d6

move properties to the top of the file

e35827a

Add option to vacuum on clear to address #650

1539c54

Use self to make it easier to determine during code review whether we…

2cf367c

…'re accessing local or instance variables.

move conformances to NormalizedCache into an extension

c7deca0

Add some documentation to the SQLite stuff

467e71b

designatednerd added this to the 0.13.0 milestone Jul 20, 2019

designatednerd mentioned this pull request Jul 22, 2019

After clearing SQLite cache, SQLite causes a crash from Statement.swift #397

Closed

ZevEisenberg reviewed Jul 22, 2019

View reviewed changes

Sources/ApolloSQLite/SQLiteNormalizedCache.swift Outdated Show resolved Hide resolved

Only use VACUUM instead of [db name] VACUUM

db2ac1b

Co-Authored-By: Zev Eisenberg <zev@zeveisenberg.com>

designatednerd merged commit 831ca74 into master Jul 23, 2019

designatednerd deleted the fix/sqlite-clear branch July 23, 2019 09:29

Provide feedback