Make GraphQL response error type generic #40
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept to support extra GraphQL error keys, as mentioned in #39 . I plan to test and refine this over the coming days in my application.
The type parameter name
GraphQLErrorType
seems suboptimal, but given theGraphQLError
was already taken by a concrete type, it seemed like the least worst option 😛 . Here are some others:GraphQLError
(perhapsGraphQLConcreteError
or similar) and useGraphQLError
as the type parameter nameErrorType
as the type parameter name. The compiler gives you "ErrorType has been renamed to Error" warnings.I wanted to get feedback before investing the time to update the unit tests.