Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GraphQL response error type generic #40

Closed
wants to merge 1 commit into from

Conversation

sibljon
Copy link

@sibljon sibljon commented Jan 11, 2017

This is a proof of concept to support extra GraphQL error keys, as mentioned in #39 . I plan to test and refine this over the coming days in my application.

The type parameter name GraphQLErrorType seems suboptimal, but given the GraphQLError was already taken by a concrete type, it seemed like the least worst option 😛 . Here are some others:

  • [POSSIBLE] Rename struct GraphQLError (perhaps GraphQLConcreteError or similar) and use GraphQLError as the type parameter name
  • [NOT POSSIBLE] Use ErrorType as the type parameter name. The compiler gives you "ErrorType has been renamed to Error" warnings.

I wanted to get feedback before investing the time to update the unit tests.

@apollo-cla
Copy link

@sibljon: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants