Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on apollo CLI for fetching schema #1935

Merged
merged 49 commits into from
Sep 16, 2021
Merged

Remove dependency on apollo CLI for fetching schema #1935

merged 49 commits into from
Sep 16, 2021

Commits on Sep 10, 2021

  1. Pull downloader into its own file

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    1de9881 View commit details
    Browse the repository at this point in the history

  2. Use URL downloader in CLI downloader

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    3610cfa View commit details
    Browse the repository at this point in the history

  3. Update headers to take both key and value

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    93ec2e1 View commit details
    Browse the repository at this point in the history

  4. Add Apollo-Use-Only method to create a non-type safe GraphQL request

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    d277334 View commit details
    Browse the repository at this point in the history

  5. Add methods for direct download from registry and introspection rathe… 

    …r than using the JS CLI
    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    6a7a606 View commit details
    Browse the repository at this point in the history

  6. Revert "Add Apollo-Use-Only method to create a non-type safe GraphQL … 

    …request"

This reverts commit 9aac6367a611260ffea12e3b0ae965b999d9b9d3.
    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    2e546a5 View commit details
    Browse the repository at this point in the history

  7. Pull untyped request body creator into codegen lib 

    I tried pulling some of this stuff into Core but you have to pull so much into core to make it work since by default it uses a bunch of `Apollo` only types that it kind of defeats the point of keeping core small, and realistically the only place where we even *should* be using untyped queries is in grabbing the schema.
    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    8aa6e46 View commit details
    Browse the repository at this point in the history

  8. update types on codegen tests

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    b314b97 View commit details
    Browse the repository at this point in the history

  9. Pull out usage of the typescript CLI 🎉

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    95744c6 View commit details
    Browse the repository at this point in the history

  10. Make sure URL request headers are properly set

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    b465bbb View commit details
    Browse the repository at this point in the history

  11. don't try to import all of apollo 🤦‍♀️

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    153a3c2 View commit details
    Browse the repository at this point in the history

  12. Make sure keys are sorted

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    5bff0ef View commit details
    Browse the repository at this point in the history

  13. Make sure folder is created before trying to write to it

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    8439a0a View commit details
    Browse the repository at this point in the history

  14. Update tests

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    f791135 View commit details
    Browse the repository at this point in the history

  15. Update that we should really only be getting SDL files, not JSON, bec… 

    …ause the JSON is so damned huge
    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    af8a782 View commit details
    Browse the repository at this point in the history

  16. start adding and testing downloading the schema from the graph registry

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    812d12a View commit details
    Browse the repository at this point in the history

  17. Turns out variant is actually required

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    e8c4faf View commit details
    Browse the repository at this point in the history

  18. fix expected file name

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    815a718 View commit details
    Browse the repository at this point in the history

  19. get rid of arguments parameter, update custom debug strings

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    5c7769f View commit details
    Browse the repository at this point in the history

  20. Turns out you have to _throw_ the error rather than just creating it … 

    …🤦‍♀️
    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    59dde6b View commit details
    Browse the repository at this point in the history

  21. Check that downloaded info from introspection query can be loaded int… 

    …o an actual schema rather than just being json
    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    2600a93 View commit details
    Browse the repository at this point in the history

  22. test that downloaded SDL schema from the Registry can be turned into … 

    …a schema
    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    9fe96ee View commit details
    Browse the repository at this point in the history

  23. Clarify where we're converting from a downloaded Registry file vs a d… 

    …ownloaded Introspection file.
    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    83c1e57 View commit details
    Browse the repository at this point in the history

  24. first swipe at adding SDL printing for introspection

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    3c5e177 View commit details
    Browse the repository at this point in the history

  25. Updated JS bundle

    @calvincestari
    calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    3c36ebc View commit details
    Browse the repository at this point in the history

  26. add tslib to the package.json so it gets pulled in if you haven't glo… 

    …bally installed it
    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    3771b2d View commit details
    Browse the repository at this point in the history

  27. actual, successful swipe at getting introspection JSON converted to SDL.

    @designatednerd @calvincestari
    designatednerd authored and calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    2426893 View commit details
    Browse the repository at this point in the history

  28. Update integration tests for new schema downloader

    @calvincestari
    calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    07f440d View commit details
    Browse the repository at this point in the history

  29. Organize code by section

    @calvincestari
    calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    8a77f00 View commit details
    Browse the repository at this point in the history

  30. Fix spelling mistake

    @calvincestari
    calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    6e9aee8 View commit details
    Browse the repository at this point in the history

  31. Clean-up CLIDownloader API and tests

    @calvincestari
    calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    c11e734 View commit details
    Browse the repository at this point in the history

  32. Clean-up URLDownloader and add tests

    @calvincestari
    calvincestari committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    fd02502 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2021

  1. Ignore URLDownloader test output

    @calvincestari
    calvincestari committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    7c5ae6f View commit details
    Browse the repository at this point in the history

  2. Fix library import for ApolloPerformanceTests

    @calvincestari
    calvincestari committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    c0338b3 View commit details
    Browse the repository at this point in the history

  3. Improve test feedback when not setting a request handler

    @calvincestari
    calvincestari committed Sep 11, 2021
    Configuration menu
    Copy the full SHA
    d7efb14 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. Remove comment about public use of UntypedGraphQLRequestBodyCreator

    @calvincestari
    calvincestari committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    a185a04 View commit details
    Browse the repository at this point in the history

  2. Improve test names and operation

    @calvincestari
    calvincestari committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    c185d48 View commit details
    Browse the repository at this point in the history

  3. Refactored ApolloSchemaDownloadConfiguration 

    * renamed for better context
* improved initializer
    @calvincestari
    calvincestari committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    ed9bc43 View commit details
    Browse the repository at this point in the history

  4. Refactor ApolloSchemaDownloader

    @calvincestari
    calvincestari committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    676882c View commit details
    Browse the repository at this point in the history

  5. Update schema download script for changed API

    @calvincestari
    calvincestari committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    e99e052 View commit details
    Browse the repository at this point in the history

  6. Remove irrelevant schema download integration test

    @calvincestari
    calvincestari committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    67dddc0 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Move linked library from ApolloPerformanceTest target to ApolloTestSu… 

    …pport target
    @calvincestari
    calvincestari committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    ce93e15 View commit details
    Browse the repository at this point in the history

  2. Move MockNetworkSession to ApolloCodegenTestSupport target

    @calvincestari
    calvincestari committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    436d1eb View commit details
    Browse the repository at this point in the history

  3. Add SDL validation to StarWarsApolloSchemaDownloaderTests

    @calvincestari
    calvincestari committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    c524531 View commit details
    Browse the repository at this point in the history

  4. Add registry-based ApolloSchemaDownloader integration test

    @calvincestari
    calvincestari committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    062225c View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Finish unit tests for ApolloSchemaDownloader

    @calvincestari
    calvincestari committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    6e5e1dc View commit details
    Browse the repository at this point in the history

  2. Add Apollo prefix to 'registry' usage in schema downloader

    @calvincestari
    calvincestari committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    7b0c777 View commit details
    Browse the repository at this point in the history

  3. Add documentation to ApolloSchemaDownloadConfiguration

    @calvincestari
    calvincestari committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    7fffa63 View commit details
    Browse the repository at this point in the history

  4. Fix ApolloServerIntegrationTests for enum value renaming

    @calvincestari
    calvincestari committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    6216e33 View commit details
    Browse the repository at this point in the history