Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update subscriptions tutorial to be compatible with recent changes #1893

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

calvincestari
Copy link
Member

Updates to the subscriptions tutorial to make the sample code compatible with recent changes to WebSocketTransport, DefaultInterceptorProvider and ApolloClient .

Answers #1885

Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though this is the documentation, not the tutorial 🤓

Probably ought to wait to merge it until this ships.

@calvincestari
Copy link
Member Author

calvincestari commented Aug 5, 2021

LGTM though this is the documentation, not the tutorial 🤓

Derpy derp! 🤦🏻

@calvincestari calvincestari added 2021-08 docs Focuses on documentation changes no-changelog Indicates that changes from this PR do not need to be included in the changelog for their release. labels Aug 5, 2021
@calvincestari
Copy link
Member Author

Probably ought to wait to merge it until this ships.

Is there anything to ship for this still? I believe the underlying changes were released in 0.45; the changelog specified them as breaking changes.

@AnthonyMDev
Copy link
Contributor

Yeah, we should merge this now. Right @designatednerd ?

@designatednerd
Copy link
Contributor

Ahh I thought some of this was tied to the changes that just got merged. Never mind!

@calvincestari calvincestari merged commit 0d987b4 into main Aug 5, 2021
@calvincestari calvincestari deleted the discussions/1885 branch August 5, 2021 18:07
ketenshi added a commit to scorebet/apollo-ios that referenced this pull request Aug 16, 2021
* main: (856 commits)
  Add execution tests for ApolloClient clearCache callback queue (apollographql#1901)
  Use the provided callback queue instead of the store's default. (apollographql#1904)
  chore(deps): update dependency path-parse to 1.0.7 [security] (apollographql#1899)
  Release - 0.46.0 (apollographql#1897)
  Update subscriptions tutorial to be compatible with recent changes (apollographql#1893)
  Add docs and improve merging of records from WebSockets into cache. (apollographql#1892)
  Publish response from the `WebSocketTransport` to the `ApolloStore` (apollographql#1889)
  fix(deps): update dependency gatsby-theme-apollo-docs to v4.7.14
  Removing Swift codegen (v1) (apollographql#1873)
  Update toolchain versions used by circleci (apollographql#1875)
  fix(deps): update dependency gatsby-theme-apollo-docs to v4.7.13
  Community Updates - ROADMAP/README (apollographql#1867)
  [Release] - 0.45.0 (apollographql#1862)
  WebSocket Fixes - Revert to Starscream 3.x and invert dependency (apollographql#1861)
  Docs/discussions_2_community branch changes (apollographql#1858)
  Replace spectrum with Discourse (apollographql#1857)
  fix(deps): update dependency gatsby-theme-apollo-docs to v4.7.12
  Configure Renovate (apollographql#1854)
  Revert "Reconfiguring renovate 2/2"
  Reconfiguring renovate 2/2
  ...

# Conflicts:
#	Sources/Apollo/GraphQLQueryWatcher.swift
#	Sources/ApolloWebSocket/WebSocketTransport.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Focuses on documentation changes no-changelog Indicates that changes from this PR do not need to be included in the changelog for their release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants