Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for pattern matching cache delete #1852

Merged
merged 2 commits into from
Jul 6, 2021
Merged

Update documentation for pattern matching cache delete #1852

merged 2 commits into from
Jul 6, 2021

Conversation

calvincestari
Copy link
Member

This updates the documentation for cache delete - it should have been part of #1848.

How to test the changes

  1. Navigate to apollo-ios/docs in a terminal window
  2. Execute npm install
  3. Execute npm start
  4. Open a browser to the link provided in the console
  • Validate that the documentation for 'Direct cache access' -> 'delete' shows the updates and makes sense.

@AnthonyMDev
Copy link
Contributor

We should wait to push this until we are ready to cut the next release. Docs get deployed as soon as they are pushed to main.

designatednerd
designatednerd approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@designatednerd designatednerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one note, otherwise LGTM

docs/source/caching.mdx Outdated Show resolved Hide resolved
@calvincestari calvincestari self-assigned this Jun 28, 2021
@designatednerd
Copy link
Contributor

:shipit:

@AnthonyMDev AnthonyMDev changed the base branch from main to networking-docs-update July 6, 2021 21:59
@AnthonyMDev
Copy link
Contributor

I'm merging this into the networking-docs-update branch, which is poorly named now, as I'm just using it as the branch for the 0.45.0 release.

@AnthonyMDev AnthonyMDev merged commit 8b67618 into networking-docs-update Jul 6, 2021
@AnthonyMDev AnthonyMDev deleted the pattern-matching-docs-update branch July 6, 2021 22:00
AnthonyMDev added a commit that referenced this pull request Jul 6, 2021
@AnthonyMDev @calvincestari
[Release] - 0.45.0 (#1862)
84e28fe 
* Updated docs for networking changes

* Update changelog and bump version

* Update documentation for pattern matching cache delete (#1852)

* Update documentation for pattern matching cache delete

* Add note about cache pattern removal performance

Co-authored-by: Calvin Cestari <calvincestari@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@designatednerd designatednerd designatednerd approved these changes

@AnthonyMDev AnthonyMDev Awaiting requested review from AnthonyMDev

Assignees

@calvincestari calvincestari

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calvincestari @AnthonyMDev @designatednerd