Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a data race that occasionally causes a crash #1740

Merged
merged 3 commits into from
Apr 23, 2021
Merged

Fixed a data race that occasionally causes a crash #1740

merged 3 commits into from
Apr 23, 2021
+22 −4

Commits on Apr 23, 2021

  1. Fixed a data race that occasionally causes a crash if webSocketTransp… 

    …ort.closeConnection() and webSocketTransport.initServer() are called in succession. Fix was verified with Xcode Thread sanitizer
    @designatednerd
    Seppo Tomperi authored and designatednerd committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    6ada368 View commit details
    Browse the repository at this point in the history

  2. Added missing self

    @designatednerd
    Seppo Tomperi authored and designatednerd committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    fcc26cc View commit details
    Browse the repository at this point in the history

  3. Added a test which triggers thread sanitizer error without the fix

    @designatednerd
    Seppo Tomperi authored and designatednerd committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    69466ad View commit details
    Browse the repository at this point in the history