Initial file upload concept

[wpK]

As discussed in #114, this is an example of file upload support without forcing to a specific server spec.

I made this PR to get the conversation going. The naming, progress handling, GraphQLFile input error handling all need to be improved on.

An example of use:

let imageData: Data = ...
let imageFileURL: URL = ...
let pdfInputStream: InputStream = ...
let pdfContentLength: UInt64 = ...

var files: [GraphQLFile] = []
files.append(GraphQLFile(fieldName: "files.0", originalName: "test-file-1.png", mimeType: "image/png", data: imageData))
files.append(GraphQLFile(fieldName: "files.1", originalName: "test-file-2.png", mimeType: "image/png", fileURL: imageData))
files.append(GraphQLFile(fieldName: "files.2", originalName: "test-file-3.pdf", mimeType: "application/pdf", inputStream: pdfData, contentLength: pdfContentLength))

let mutation = MultipleUploadMutation(files: files.map({Upload(fieldName: $0.fieldName, name: $0.originalName, type: $0.mimeType, size: $0.count)}))

let progressHandler = { progress in
  print("Upload progress: \(progress)")
}

let client = ApolloClient( ... )

// progressHandler is optional
client.performUpload(mutation: mutation, files: files, progressHandler: progressHandler) { (result, error) in
  ...
}

[apollo-cla]

@wpK: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[martijnwalraven]

@wpK: Thanks a lot, happy to see this get in! I'll try to take a closer look tomorrow or else over the weekend.

[martijnwalraven]

Hey, I'm sorry I haven't gotten to this yet. I'll be on vacation for the next week and a half, but I'll take a look after.

[wpK]

@martijnwalraven No problem. Enjoy your vacation!

[FellnerDotDev]

@martijnwalraven I hope you have had a pleasant vacation. Is there any chance that the merge conflicts get resolved in the near future?

[martijnwalraven]

@TheFellner I'm caught up in preparing for GraphQL Summit right now, but let's get back to this next week. I don't think this is ready to be merged, but it's a good starting point for discussing API design.

[gorbat-o]

Hey,

Is it still something you are working on ?

Thanks :)

[dphov]

Please, someone, resolve this PR
@wpK

[vinayan3]

Is there anything we can do to help get this PR through? It'll be super useful to have it working in the client.

[LeeWong]

Please merge this PR. Thanks.

[highthem]

any news about this? is it released?
@wpK
@martijnwalraven

[marinofelipe]

This would be a great addition for us. Is there any news about it? Can we help somehow?

[psi-gh]

Waiting for this.

[tylergets]

Would also support this pull request, file uploads are mainstreamed in apollo-server now

[otri]

I'm hoping to get this working on my fork here:
https://github.com/otri/apollo-ios

It's still a work in progress today, but I hope to have it running very soon. I've resolved all the merge conflicts with master.

[otri]

Okay I've learned that there's a lot more to the schema codegen. Would need Apollo to figure this one out. My fork corrects for a conflict with Progress, but I couldn't actually get the implementation for the mutation hooked up.

[the-scott-davis]

This is so needed.... seems like a major oversight to not support this. @otri I took at look at your PR, looks solid, but as you said, need support from the Apollo team for the codegen part it appears.

[kimdv]

Hi @wpK and @martijnwalraven

Do you need any help here?
I'm looking for this feature, so if you need help feel free to reach out! 🚀

[otri]

I've learned that using graphql for file transport is not a good idea. Turns out it's best to push your files using a regular REST API, and let the meta data reflect the availability of the files. This keeps the channel for graphql changes fast and light, and the REST API can be built to be scalable for larger bulk transport in the future.

On Tue, Jun 11, 2019 at 22:31 Kim de Vos ***@***.***> wrote: Hi @wpK <https://github.com/wpK> and @martijnwalraven <https://github.com/martijnwalraven> Do you need any help here? I'm looking for this feature, so if you need help feel free to reach out! 🚀 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#116?email_source=notifications&email_token=AAHHYAVDJM4BPGJE753L3QDPZ6SKZA5CNFSM4DUWQMW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXND47A#issuecomment-500842108>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHHYAWHE757CVKII4HKXQ3PZ6SKZANCNFSM4DUWQMWQ> .

--

…

_______________________ Aaron Hilton Steampunk Digital mobile: +81 80 3947 6874 <+818039476874> skype: otristudios facetime: aaron@steampunk.digital Monocle 3D Portrait <https://goo.gl/w0JV66>

[designatednerd]

@wpK Are you interested in continuing this PR? If not I can close it out for you and take a stab myself.

[otri]

Nope, go for it.

On Thu, Jul 11, 2019 at 04:27 Ellen Shapiro ***@***.***> wrote: @wpK <https://github.com/wpK> Are you interested in continuing this PR? If not I can close it out for you and take a stab myself. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#116?email_source=notifications&email_token=AAHHYAVMO5Y3FCNDH7EZGODP6YZ2PA5CNFSM4DUWQMW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZUPQ2A#issuecomment-510195816>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHHYAWGCPQM7YFQ6JPR46LP6YZ2PANCNFSM4DUWQMWQ> .

--

…

_______________________ Aaron Hilton Steampunk Digital mobile: +81 80 3947 6874 <+818039476874> skype: otristudios facetime: aaron@steampunk.digital Monocle 3D Portrait <https://goo.gl/w0JV66>

[designatednerd]

Thanks @otri - I'd like to get that confirmation from the original author, @wpK, before I close this (or if I don't hear from him in a couple weeks, I'll close it anyway).

[kimdv]

@designatednerd I have a branch fork with the 0.10.1 working with file upload.
https://github.com/trifork/apollo-ios

I can rebase to 0.11.0 and open an PR?

[designatednerd]

@kimdv absolutely!

[designatednerd]

Closing this in favor of #626 since that one's been rebased

[wpK]

@designatednerd I haven't touched this in awhile. Last time I checked the Apollo server was adding official file upload support and I never got around to updating to the new spec. I'll watch #626 and when I have some more time try to contribute where I can.

[designatednerd]

@wpK Thank you - Yeah #626 is ready for a look if you've got questions!