Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add and test errors instead of nil failures for creating a GraphQL file and/or stream #1089

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Add and test errors instead of nil failures for creating a GraphQL file and/or stream #1089

merged 2 commits into from
Mar 18, 2020

Conversation

designatednerd
Copy link
Contributor

Building off #1086, this PR adds explicit errors and failure modes, and tests them, for creating a GraphQLFile or an InputStream based on either Data or a fileURL.

cc @josueruiz7

@designatednerd designatednerd added this to the 0.24.0 milestone Mar 18, 2020
@designatednerd designatednerd merged commit 020f089 into master Mar 18, 2020
@designatednerd designatednerd deleted the cleanup/errors branch March 19, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josueruiz7 josueruiz7 josueruiz7 approved these changes

Assignees
No one assigned
Labels
uploading
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@designatednerd @josueruiz7