Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: line/realtime test #4557

Merged

Conversation

Sebastian-Webster
Copy link
Contributor

Fixed line/realtime test

In #4515 a change was made to the line/realtime sample so that its setInterval would stop after 2 seconds so Puppeteer wouldn't timeout from waiting for the setInterval to be cleared. That change was not added to the XML file so whenever samples were rebuilt the test would start to cause an issue again.

This pull request adds that change to the XML file so the test won't cause issues when samples are rebuilt. This pull request also makes the setInterval stop after 2 seconds only if it is used in e2e testing.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@junedchhipa junedchhipa merged commit 20863df into apexcharts:main Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants