Separate Server from Connection
#11675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The only parts of the interface they share are the `close` operation and the `sock` and `addr` fields. They have very little in common and I think the inheritance is kind of forced just for a minor convenience and not serving a useful purpose. To make sure this doesn't develop into a larger inheritance mess, I'd like to separate these now. This also puts `Server` in its own files for better organization and faster compilation.
cmcfarlen
reviewed
Aug 14, 2024
* Use the correct address for accept events The Server's `addr` can be different from its `accept_addr`. These are not interchangeable.
cmcfarlen
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only parts of the interface they share are the
closeoperation and thesockandaddrfields. They have very little in common and I think the inheritance is kind of forced just for a minor convenience and not serving a useful purpose. To make sure this doesn't develop into a larger inheritance mess, I'd like to separate these now. This also putsServerin its own files for better organization and faster compilation.