-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: storage.yaml #11000
Doc: storage.yaml #11000
Conversation
Co-authored-by: Alan M. Carroll <amc@apache.org>
|
||
cache: # file level key | ||
spans: # | ||
- id: # identifier / name of the span |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very bike-shedding, but calling this name
is better than id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better and you can differentiate it from volume:id
, which is a different object I know but a fast reader can confuse.
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community. |
This pull request has been automatically marked as stale because it has not had recent activity. Marking it stale to flag it for further consideration by the community. |
Draft PR for discuss details of making
volume.config
andstorage.config
into one YAML file.Most of the docs were written by @SolidWallOfCode last year and I made some changes from his draft.
Differences are
storage.yaml
instead ofcache.yaml
integer
, because it's referred fromhosting.config
( we can change itstring
later, but I'd like to leave it as is for now )span[].size
I'll open another PR for implementation.