Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed Add Metrics to Tree Chart (#29158) #30679

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+1 −3
Open

fix: fixed Add Metrics to Tree Chart (#29158) #30679

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19151d1
fix: fixed Add Metrics to Tree Chart (#29158)
SBIN2010 Oct 22, 2024
35aaeb6
fix: clear modal after CSS templates is added
SBIN2010 Oct 22, 2024
db3afda
Revert "fix: clear modal after CSS templates is added"
SBIN2010 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions superset-frontend/plugins/plugin-chart-echarts/src/Tree/controlPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,7 @@ const controlPanel: ControlPanelConfig = {
{
name: 'metric',
config: {
...optionalEntity,
type: 'DndMetricSelect',
label: t('Metric'),
...sharedControls.metric,
description: t('Metric for node values'),
},
},
Expand Down
5 changes: 4 additions & 1 deletion superset-frontend/src/features/cssTemplates/CssTemplateModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,10 @@ const CssTemplateModal: FunctionComponent<CssTemplateModalProps> = ({
if (onCssTemplateAdd) {
onCssTemplateAdd();
}

setCurrentCssTemplate({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SBIN2010 Thanks for the bug fix.
Please check if this change is related to the current tree chart error.

Copy link
Author

@SBIN2010 SBIN2010 Oct 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

justinpark
Oh no, this commit is not to fix that bug. It's for clearing the modal after adding css templates.
Revert this commit.

template_name: '',
css: '',
});
hide();
});
}
Expand Down
Loading