fix: fixed Add Metrics to Tree Chart (#29158) #30679
Open
+1
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBIN2010
changed the title
SBIN2010
changed the title
justinpark
reviewed
Oct 23, 2024
| @@ -131,7 +131,10 @@ const CssTemplateModal: FunctionComponent<CssTemplateModalProps> = ({ | |||
| if (onCssTemplateAdd) { | |||
| onCssTemplateAdd(); | |||
| } | |||
|
|
|||
| setCurrentCssTemplate({ | |||
There was a problem hiding this comment.
@SBIN2010 Thanks for the bug fix.
Please check if this change is related to the current tree chart error.
There was a problem hiding this comment.
justinpark
Oh no, this commit is not to fix that bug. It's for clearing the modal after adding css templates.
Revert this commit.
This reverts commit 35aaeb6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixed add metrics in the tree chart page
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before:
after:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION