Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Cypress CI process while opening PR from a fork #29098

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix: Cypress CI process while opening PR from a fork #29098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8074a9
chore: test Cypress process while opening PR from a fork
mistercrunch Jun 5, 2024
0bcd0b7
removing ref to go with the default option in case of pull_request or…
mistercrunch Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/superset-e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ jobs:
if: github.event_name == 'push' || github.event_name == 'pull_request'
uses: actions/checkout@v2
with:
ref: ${{ github.event.pull_request.head.ref || github.ref }}
persist-credentials: false
submodules: recursive
- name: Checkout using ref (workflow_dispatch)
Expand Down
2 changes: 0 additions & 2 deletions superset/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
"""Package's main module!"""
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this silly string to trigger CI as it only runs certain steps based on which folders/files have changed


from flask import current_app, Flask
from werkzeug.local import LocalProxy

Expand Down
Loading