fix: Cypress CI process while opening PR from a fork #29098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
github_actions
mistercrunch
changed the title
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
mistercrunch
commented
Jun 5, 2024
| @@ -14,8 +14,6 @@ | |||
| # KIND, either express or implied. See the License for the | |||
| # specific language governing permissions and limitations | |||
| # under the License. | |||
| """Package's main module!""" | |||
There was a problem hiding this comment.
I removed this silly string to trigger CI as it only runs certain steps based on which folders/files have changed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29098 +/- ##
==========================================
+ Coverage 60.48% 70.31% +9.82%
==========================================
Files 1931 1951 +20
Lines 76236 77611 +1375
Branches 8568 8756 +188
==========================================
+ Hits 46114 54571 +8457
+ Misses 28017 20915 -7102
- Partials 2105 2125 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eschutho
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed in #28774 (thanks for catching this @rusackas), I broke the PR-from-fork in my recently merged PR here #29077 .
This PR removes special handling of
ref:on github_event in (pull_request, push)