-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dockefile): broken docker image #25251
fix(dockefile): broken docker image #25251
Conversation
The docker image was missing dependencies needed for the frontend build. This commit installs the dependencies python3, make, gcc and g++.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockerfile
Outdated
RUN apt-get update -q | ||
RUN apt-get install -yq python3 make gcc g++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think best practice would be
RUN apt-get update -q && apt-get install -yq python3 make gcc g++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call-out, I updated it to follow the same pattern as the rest of the Dockerfile
|
||
RUN apt-get update -q \ | ||
&& apt-get install -yq --no-install-recommends \ | ||
python3 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we pin the python3
lib here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's best to pin it for sure, however python3.9
is not available in the package manager. The alternative is to install python from source, however that takes additional time.
Totally open to alternative solutions as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. I'm fine with this, assuming it's needed to build some NPM libs locally...
SUMMARY
The docker image was missing dependencies needed for the frontend build.
This commit installs the dependencies python3, make, gcc and g++.
TESTING INSTRUCTIONS
docker build . -t superset --no-cache
ADDITIONAL INFORMATION