fix(dockefile): broken docker image #25251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker image was missing dependencies needed for the frontend build. This commit installs the dependencies python3, make, gcc and g++.
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
Dockerfile
Outdated
Comment on lines
29
to
30
| RUN apt-get update -q | ||
| RUN apt-get install -yq python3 make gcc g++ |
There was a problem hiding this comment.
I think best practice would be
RUN apt-get update -q && apt-get install -yq python3 make gcc g++There was a problem hiding this comment.
Good call-out, I updated it to follow the same pattern as the rest of the Dockerfile
craig-rueda
reviewed
Sep 11, 2023
|
|
||
| RUN apt-get update -q \ | ||
| && apt-get install -yq --no-install-recommends \ | ||
| python3 \ |
There was a problem hiding this comment.
Should we pin the python3 lib here?
There was a problem hiding this comment.
It's best to pin it for sure, however python3.9 is not available in the package manager. The alternative is to install python from source, however that takes additional time.
Totally open to alternative solutions as well
There was a problem hiding this comment.
Understood. I'm fine with this, assuming it's needed to build some NPM libs locally...
craig-rueda
approved these changes
Sep 11, 2023
michael-s-molina
added
the
v3.0
michael-s-molina
pushed a commit
that referenced
this pull request
Sep 12, 2023
eschutho
pushed a commit
to Superset-Community-Partners/superset
that referenced
this pull request
Sep 21, 2023
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The docker image was missing dependencies needed for the frontend build.
This commit installs the dependencies python3, make, gcc and g++.
TESTING INSTRUCTIONS
docker build . -t superset --no-cacheADDITIONAL INFORMATION