-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): scroll position after run current sql #24965
fix(sqllab): scroll position after run current sql #24965
Conversation
/testenv up |
@michael-s-molina Ephemeral environment spinning up at http://35.86.122.33:8080. Credentials are |
Query is failing when running without selecting the whole query. Screen.Recording.2023-08-14.at.10.00.52.mov |
This is not a bug. you missed the semicolon in the first sql block
|
@michael-s-molina This is not a bug. you missed the semicolon in the first sql block
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit 155cf54)
SUMMARY
The scroll position after run current sql(ctrl + shift + enter) moved to bottom when hit within the first paragraph.
This commit fixes this bug by storing the current scroll after running the query.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
after--scroll-after-current-sql.mov
Before:
before--scroll-after-current-sql.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION