Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CSP, bump FAB to 4.3.4 #24646

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jul 10, 2023

SUMMARY

Bump FAB to 4.3.4 to get CSP fixes and others:

Changelog:

  • fix: select filters spacing, theme and operation select [Daniel Vaz Gaspar]
  • refactor: Refactored logging functions to consistently use lazy interpolation [Bruce]
  • feat: add optional flask-talisman and use csp nonce on scripts [Daniel Vaz Gaspar]
  • chore: improve tests and test data load [Daniel Vaz Gaspar]

https://github.com/dpgaspar/Flask-AppBuilder/blob/master/CHANGELOG.rst#improvements-and-bug-fixes-on-434

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks like OAuth is working now!

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #24646 (e027548) into master (fe2c14f) will increase coverage by 10.74%.
The diff coverage is n/a.

❗ Current head e027548 differs from pull request most recent head 7435d95. Consider uploading reports for the commit 7435d95 to get more accurate results

@@             Coverage Diff             @@
##           master   #24646       +/-   ##
===========================================
+ Coverage   58.33%   69.08%   +10.74%     
===========================================
  Files        1907     1907               
  Lines       74153    74153               
  Branches     8182     8182               
===========================================
+ Hits        43255    51225     +7970     
+ Misses      28775    20805     -7970     
  Partials     2123     2123               
Flag Coverage Δ
hive 54.14% <ø> (ø)
mysql 79.47% <ø> (?)
postgres 79.56% <ø> (?)
presto 54.04% <ø> (ø)
python 83.54% <ø> (+22.41%) ⬆️
sqlite 78.12% <ø> (?)
unit 54.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 299 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpgaspar dpgaspar merged commit 4881328 into apache:master Jul 10, 2023
29 checks passed
@dpgaspar dpgaspar deleted the fix/bump-fab-4.3.4 branch July 10, 2023 19:09
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 10, 2023
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants