fix(dashboard): max call size stack error

[justinpark]

SUMMARY

There's a case that dashboardLayout consists of the circular structure. Following is the case:

This causes the max. call stack size error in findTabsWithChartsInScopeHelper.
This commit fixes the infinite recursive loop in the circular structure.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
No error

Before:
Maximum call stack size exceeded

TESTING INSTRUCTIONS

unit test with circular structure

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #24304 (54f97aa) into master (9df8d8d) will decrease coverage by 1.76%.
The diff coverage is 93.40%.

❗ Current head 54f97aa differs from pull request most recent head 14ecc0c. Consider uploading reports for the commit 14ecc0c to get more accurate results

@@            Coverage Diff             @@
##           master   #24304      +/-   ##
==========================================
- Coverage   68.30%   66.54%   -1.76%     
==========================================
  Files        1957     1957              
  Lines       75594    75627      +33     
  Branches     8224     8225       +1     
==========================================
- Hits        51637    50329    -1308     
- Misses      21849    23185    +1336     
- Partials     2108     2113       +5     

Flag	Coverage Δ
hive	?
javascript	54.76% <48.14%> (+0.03%)	⬆️
presto	?
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts	100.00% <ø> (ø)
...hart-echarts/src/BigNumber/BigNumberTotal/index.ts	66.66% <ø> (ø)
...arts/src/BigNumber/BigNumberWithTrendline/index.ts	66.66% <ø> (ø)
...t-frontend/plugins/plugin-chart-table/src/index.ts	66.66% <ø> (ø)
...nd/src/components/ErrorMessage/BasicErrorAlert.tsx	93.75% <ø> (ø)
superset-frontend/src/components/Table/index.tsx	75.29% <ø> (ø)
superset-frontend/src/components/Tags/Tag.tsx	62.50% <ø> (ø)
...veFilters/FilterBar/FilterControls/FilterValue.tsx	5.66% <0.00%> (-0.06%)	⬇️
superset-frontend/src/dashboard/types.ts	100.00% <ø> (ø)
...perset-frontend/src/hooks/apiResources/queryApi.ts	100.00% <ø> (ø)
... and 234 more

... and 49 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[michael-s-molina]

LGTM