Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dashboard page full xlsx export #24287

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

vitoldi
Copy link
Contributor

@vitoldi vitoldi commented Jun 5, 2023

SUMMARY

This is a continuation of the MR #24005 problem.

This PR adds the ability of full Excel export on the Dashboard page, when the feature flag "ALLOW_FULL_CSV_EXPORT" has "true" value.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

before

After:

after

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: ALLOW_FULL_CSV_EXPORT
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@vitoldi vitoldi changed the title added dashboard page full xlsx export feat: added dashboard page full xlsx export Jun 5, 2023
@vitoldi vitoldi changed the title feat: added dashboard page full xlsx export feat: add dashboard page full xlsx export Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #24287 (604f944) into master (18d2257) will increase coverage by 9.28%.
The diff coverage is 85.71%.

❗ Current head 604f944 differs from pull request most recent head 4551b44. Consider uploading reports for the commit 4551b44 to get more accurate results

@@            Coverage Diff             @@
##           master   #24287      +/-   ##
==========================================
+ Coverage   57.24%   66.53%   +9.28%     
==========================================
  Files        1957     1957              
  Lines       75624    75627       +3     
  Branches     8223     8224       +1     
==========================================
+ Hits        43294    50316    +7022     
+ Misses      30222    23202    -7020     
- Partials     2108     2109       +1     
Flag Coverage Δ
hive ?
javascript 54.73% <85.71%> (+<0.01%) ⬆️
presto ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/dashboard/components/SliceHeader/index.tsx 90.74% <ø> (ø)
superset/constants.py 100.00% <ø> (ø)
superset-frontend/src/utils/textUtils.ts 80.00% <50.00%> (-20.00%) ⬇️
...dashboard/components/SliceHeaderControls/index.tsx 70.40% <100.00%> (+0.61%) ⬆️
.../src/dashboard/components/gridComponents/Chart.jsx 58.26% <100.00%> (+0.73%) ⬆️
superset-frontend/src/logger/LogUtils.ts 97.22% <100.00%> (ø)

... and 360 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EugeneTorap
Copy link
Contributor

Hey @villebro @dpgaspar! Can you review the PR?

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the great work here!

test('Should "export full Excel"', async () => {
// @ts-ignore
global.featureFlags = {
[FeatureFlag.ALLOW_FULL_CSV_EXPORT]: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General note (not complaining to the author of this fine PR!): I wish we would not have used CSV all over the codebase. In the future, let's be more generic, like ALLOW_FULL_FILE_EXPORT or similar.

@villebro villebro merged commit fa82ee1 into apache:master Jun 15, 2023
@vitoldi
Copy link
Contributor Author

vitoldi commented Jun 15, 2023

LGTM, thanks for the great work here!

Thanks for the review!

@vitoldi vitoldi deleted the dashboard-page-full-xlsx-export branch June 15, 2023 14:23
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants