-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dashboard page full xlsx export #24287
feat: add dashboard page full xlsx export #24287
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24287 +/- ##
==========================================
+ Coverage 57.24% 66.53% +9.28%
==========================================
Files 1957 1957
Lines 75624 75627 +3
Branches 8223 8224 +1
==========================================
+ Hits 43294 50316 +7022
+ Misses 30222 23202 -7020
- Partials 2108 2109 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 360 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the great work here!
test('Should "export full Excel"', async () => { | ||
// @ts-ignore | ||
global.featureFlags = { | ||
[FeatureFlag.ALLOW_FULL_CSV_EXPORT]: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General note (not complaining to the author of this fine PR!): I wish we would not have used CSV
all over the codebase. In the future, let's be more generic, like ALLOW_FULL_FILE_EXPORT
or similar.
Thanks for the review! |
SUMMARY
This is a continuation of the MR #24005 problem.
This PR adds the ability of full Excel export on the Dashboard page, when the feature flag "ALLOW_FULL_CSV_EXPORT" has "true" value.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
ADDITIONAL INFORMATION