-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable SHOW_STACKTRACE by default #24137
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24137 +/- ##
==========================================
+ Coverage 68.18% 68.26% +0.08%
==========================================
Files 1952 1952
Lines 75393 75393
Branches 8204 8204
==========================================
+ Hits 51403 51469 +66
+ Misses 21884 21818 -66
Partials 2106 2106
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
Pushing for a more secure by default approach, stack traces on error responses are inherently insecure.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION