Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable SHOW_STACKTRACE by default #24137

Merged
merged 1 commit into from
May 22, 2023

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented May 19, 2023

SUMMARY

Pushing for a more secure by default approach, stack traces on error responses are inherently insecure.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #24137 (e05443d) into master (0496779) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head e05443d differs from pull request most recent head 685c2ba. Consider uploading reports for the commit 685c2ba to get more accurate results

@@            Coverage Diff             @@
##           master   #24137      +/-   ##
==========================================
+ Coverage   68.18%   68.26%   +0.08%     
==========================================
  Files        1952     1952              
  Lines       75393    75393              
  Branches     8204     8204              
==========================================
+ Hits        51403    51469      +66     
+ Misses      21884    21818      -66     
  Partials     2106     2106              
Flag Coverage Δ
hive 53.23% <100.00%> (?)
mysql 78.94% <100.00%> (+<0.01%) ⬆️
postgres 79.01% <100.00%> (+<0.01%) ⬆️
presto 53.16% <100.00%> (ø)
python 82.81% <100.00%> (+0.18%) ⬆️
sqlite 77.54% <100.00%> (+<0.01%) ⬆️
unit 53.18% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 92.02% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit 82d4249 into apache:master May 22, 2023
@dpgaspar dpgaspar deleted the fix/show-stack-trace branch May 22, 2023 09:00
@mistercrunch mistercrunch added 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.1 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants