Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sqllab): Remove functionNames from sqlLab state #24026

Conversation

justinpark
Copy link
Member

SUMMARY

Similar to #23488 and #23257, this commit migrates the functionNames state from redux to rdk-query to reduce the complexity of the queryEditor state.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

after--function_names_query.mov
Screenshot 2023-05-11 at 1 52 26 PM

Before:

before--function_names-query.mov
Screenshot_2023-05-11_at_1_51_47_PM

TESTING INSTRUCTIONS

Go to sqllab and select a database to get the associated function names
Type some part of the function name on the editor and check the autocomplete including the fetched schemas

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #24026 (d00d6ae) into master (7a55625) will increase coverage by 0.00%.
The diff coverage is 81.81%.

❗ Current head d00d6ae differs from pull request most recent head e7f9f03. Consider uploading reports for the commit e7f9f03 to get more accurate results

@@           Coverage Diff           @@
##           master   #24026   +/-   ##
=======================================
  Coverage   66.54%   66.54%           
=======================================
  Files        1941     1942    +1     
  Lines       75280    75279    -1     
  Branches     8168     8168           
=======================================
+ Hits        50093    50095    +2     
+ Misses      23098    23094    -4     
- Partials     2089     2090    +1     
Flag Coverage Δ
javascript 54.52% <81.81%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 66.66% <ø> (+0.25%) ⬆️
...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx 62.12% <ø> (+0.92%) ⬆️
superset-frontend/src/SqlLab/fixtures.ts 100.00% <ø> (ø)
...et-frontend/src/SqlLab/reducers/getInitialState.js 90.62% <ø> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js 38.46% <ø> (+0.21%) ⬆️
superset-frontend/src/SqlLab/types.ts 57.14% <ø> (ø)
...perset-frontend/src/hooks/apiResources/queryApi.ts 100.00% <ø> (ø)
...d/src/SqlLab/components/AceEditorWrapper/index.tsx 65.90% <66.66%> (-1.54%) ⬇️
...ontend/src/hooks/apiResources/databaseFunctions.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinpark justinpark merged commit 779b372 into apache:master May 23, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants