Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removes the preset-chart-xy plugin #23943

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented May 4, 2023

SUMMARY

Removes the preset-chart-xy plugin as part of the 3.0 cleanup. This plugins was deprecated for a long time and it was not registered in the default visualization registry.

TESTING INSTRUCTIONS

CI passing should be sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added risk:breaking-change Issues or PRs that will introduce breaking changes hold! On hold v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #23943 (5069156) into master (bcb145d) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 5069156 differs from pull request most recent head cde7ed4. Consider uploading reports for the commit cde7ed4 to get more accurate results

@@            Coverage Diff             @@
##           master   #23943      +/-   ##
==========================================
- Coverage   68.60%   68.57%   -0.04%     
==========================================
  Files        1943     1943              
  Lines       75208    75208              
  Branches     8216     8216              
==========================================
- Hits        51598    51573      -25     
- Misses      21499    21524      +25     
  Partials     2111     2111              
Flag Coverage Δ
hive 53.63% <ø> (ø)
mysql 79.26% <ø> (?)
postgres 79.33% <ø> (ø)
presto ?
python 83.12% <ø> (-0.07%) ⬇️
sqlite 77.86% <ø> (ø)
unit 53.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up

@michael-s-molina michael-s-molina force-pushed the delete-preset-chart-xy-plugin branch 2 times, most recently from a2a42d4 to 4b0f150 Compare May 23, 2023 19:49
@michael-s-molina michael-s-molina merged commit e922f09 into apache:master Jun 8, 2023
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels hold! On hold risk:breaking-change Issues or PRs that will introduce breaking changes size/XXL 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants