Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native-filters): Address spelling mistakes #23881

Merged
merged 1 commit into from
May 2, 2023

Conversation

john-bodley
Copy link
Member

SUMMARY

As titled.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley marked this pull request as ready for review April 30, 2023 00:10
@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Merging #23881 (6417fc2) into master (707c626) will not change coverage.
The diff coverage is n/a.

❗ Current head 6417fc2 differs from pull request most recent head d2b39ea. Consider uploading reports for the commit d2b39ea to get more accurate results

@@           Coverage Diff           @@
##           master   #23881   +/-   ##
=======================================
  Coverage   68.11%   68.11%           
=======================================
  Files        1938     1938           
  Lines       74973    74973           
  Branches     8141     8141           
=======================================
  Hits        51068    51068           
  Misses      21826    21826           
  Partials     2079     2079           
Flag Coverage Δ
hive 53.01% <ø> (ø)
mysql 78.80% <ø> (ø)
postgres 78.88% <ø> (ø)
presto 52.93% <ø> (ø)
python 82.67% <ø> (ø)
sqlite 77.39% <ø> (ø)
unit 52.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/cli/native_filters.py 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit a8e02cd into master May 2, 2023
john-bodley added a commit to airbnb/superset-fork that referenced this pull request May 10, 2023
john-bodley added a commit to airbnb/superset-fork that referenced this pull request May 22, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the john-bodley--fix-native-filters-spelling branch March 26, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants