Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(helm): Reformat helm chart templates #23681

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

dnskr
Copy link
Contributor

@dnskr dnskr commented Apr 13, 2023

SUMMARY

The PR reformats chart templates to one style with more readable blocks and indents.
The PR does not change any functionality of the chart.
Similar changes: apache/airflow#29917 apache/airflow#29941 apache/airflow#30312

TESTING INSTRUCTIONS

The following command install the chart

helm install superset helm/superset

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dnskr dnskr force-pushed the reformat_helm_chart_templates branch from e014ccb to c794cf7 Compare April 13, 2023 17:03
@craig-rueda
Copy link
Member

Did you use a tool to perform the reformat? I ask because if so, we should probably perform a lint step in CI to enforce some rules around formatting :).

@dnskr
Copy link
Contributor Author

dnskr commented Apr 17, 2023

Unfortunately no - only manual work, only hardcore :)
I'm looking for a way to automate it and I'll come back with the PR if I find. There is a similar issue apache/airflow#30546.

@craig-rueda craig-rueda merged commit 70f3cc0 into apache:master Apr 18, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants