Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Fix the test on AnnotationLayer #22876

Conversation

justinpark
Copy link
Member

SUMMARY

This commit fixes the test regression due to #22453

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

  • Before
/home/runner/work/superset/superset/superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.test.tsx:159
  expect(await _testingLibrary.screen.findByText('Chart')).toBeInTheDocument();
  • After

None

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido
Copy link
Member

geido commented Jan 26, 2023

Thanks @justinpark a fix was already merged

@justinpark
Copy link
Member Author

hotfix already merged

@justinpark justinpark closed this Jan 26, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants