Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade react-ace #22573

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

lilykuang
Copy link
Member

SUMMARY

  • current version react-ace does not support react 18, react-ace need to be upgraded before react 18 upgrade

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #22573 (25e2baa) into master (a7a4561) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22573   +/-   ##
=======================================
  Coverage   66.91%   66.91%           
=======================================
  Files        1851     1851           
  Lines       70709    70709           
  Branches     7766     7766           
=======================================
  Hits        47316    47316           
  Misses      21371    21371           
  Partials     2022     2022           
Flag Coverage Δ
javascript 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lilykuang lilykuang requested a review from a team January 3, 2023 21:48
@lilykuang lilykuang merged commit 40dba06 into apache:master Jan 4, 2023
@lilykuang lilykuang deleted the upgrade-react-ace branch January 4, 2023 17:16
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants