-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Time filter position and click in Horizontal FilterBar #22338
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22338 +/- ##
==========================================
- Coverage 66.85% 66.83% -0.02%
==========================================
Files 1847 1847
Lines 70561 70564 +3
Branches 7737 7741 +4
==========================================
- Hits 47174 47163 -11
- Misses 21380 21394 +14
Partials 2007 2007
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Let’s confirm that this isn’t breaking anything new, especially from the original PR that introduced the positioning fixes CC @jinghua-qa |
Tagging @diegomedina248 too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can we get @jinghua-qa and @diegomedina248 approvals too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/testenv up |
@geido Ephemeral environment spinning up at http://52.12.171.51:8080. Credentials are |
/testenv up FEATURE_HORIZONTAL_FILTER_BAR |
@jinghua-qa Ephemeral environment spinning up at http://52.41.118.83:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Fixes positioning of the Time filter popover as well as a bug that would close the popover when clicking on the filter from within the Horizontal FilterBar dropdown container.
BEFORE
master.mp4
AFTER
1.-.Sample.dashboard.mp4
TESTING INSTRUCTIONS
See repro steps in the videos
ADDITIONAL INFORMATION