-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): Fix autocomplete for SQL Lab #22329
Conversation
53bc7fb
to
b0de559
Compare
/testenv up |
@lyndsiWilliams Ephemeral environment spinning up at http://54.203.5.239:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## master #22329 +/- ##
=======================================
Coverage 66.84% 66.84%
=======================================
Files 1846 1846
Lines 70513 70515 +2
Branches 7726 7727 +1
=======================================
+ Hits 47132 47134 +2
Misses 21378 21378
Partials 2003 2003
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Autocompleter uses the table name in the reducer, but info is not being updated so it fails to provide autocomplete options. when opening new tabs. With these changes we make sure such info is available so options can be properly displayed.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
![error](https://user-images.githubusercontent.com/38889534/205689153-526feb1e-efad-4f55-bc7f-0b4406e38989.gif)
After:
![test](https://user-images.githubusercontent.com/38889534/205689081-25b90ded-5328-4a94-bcb4-c643ebd428e3.gif)
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION