-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): Added Latvia to countries map #22220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!
Codecov Report
@@ Coverage Diff @@
## master #22220 +/- ##
==========================================
+ Coverage 66.90% 66.92% +0.01%
==========================================
Files 1835 1834 -1
Lines 69988 69986 -2
Branches 7612 7612
==========================================
+ Hits 46825 46837 +12
+ Misses 21197 21183 -14
Partials 1966 1966
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks for this @maleksan ! Could you add a screenshot to the description showing the map in action? |
Added. Please add this new LV map into the next release. |
Hi, I mostly meant showing a screenshot of the new map in Superset, not the notebook. Also, if you don't mind, please add the notebook changes to this PR so it's up to date. |
|
/testenv up |
@villebro Ephemeral environment spinning up at http://54.203.72.96:8080. Credentials are |
@maleksan I spun up test env and verified that the chart works as expected and added a screenshot to the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! 🇱🇻
Ephemeral environment shutdown and build artifacts deleted. |
@villebro, |
@maleksan I believe this is included in the current 2.1.0 release candidate that's up for vote |
SUMMARY
Added Latvia to countries map
SCREENSHOTS
New map in Country Map viz:
![image](https://user-images.githubusercontent.com/33317356/203977248-76fd1b06-3f7d-437b-a1ce-d59e45e954fb.png)
Updated notebook:
![image](https://user-images.githubusercontent.com/73186636/203947626-b309e2ad-619c-49f4-9cbc-06e719dc90d3.png)
![image](https://user-images.githubusercontent.com/73186636/203949991-fdb9726e-fd84-44ce-a980-8b44c513e3be.png)
TESTING INSTRUCTIONS
Clone the repo and go to its root directory. Run the following shell commands:
cd superset-frontend && npm install
npm run plugins:storybook