Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Added Latvia to countries map #22220

Merged
merged 2 commits into from
Nov 25, 2022
Merged

feat(chart): Added Latvia to countries map #22220

merged 2 commits into from
Nov 25, 2022

Conversation

maleksan
Copy link
Contributor

@maleksan maleksan commented Nov 24, 2022

SUMMARY

Added Latvia to countries map

SCREENSHOTS

New map in Country Map viz:
image

Updated notebook:
image
image

TESTING INSTRUCTIONS

Clone the repo and go to its root directory. Run the following shell commands:

cd superset-frontend && npm install
npm run plugins:storybook

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #22220 (7fb3e65) into master (1831e8c) will increase coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 7fb3e65 differs from pull request most recent head 33c4a0f. Consider uploading reports for the commit 33c4a0f to get more accurate results

@@            Coverage Diff             @@
##           master   #22220      +/-   ##
==========================================
+ Coverage   66.90%   66.92%   +0.01%     
==========================================
  Files        1835     1834       -1     
  Lines       69988    69986       -2     
  Branches     7612     7612              
==========================================
+ Hits        46825    46837      +12     
+ Misses      21197    21183      -14     
  Partials     1966     1966              
Flag Coverage Δ
javascript 53.74% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/index.ts 100.00% <ø> (ø)
...t-controls/src/sections/echartsTimeSeriesQuery.tsx 33.33% <ø> (ø)
...rt-controls/src/shared-controls/customControls.tsx 0.00% <0.00%> (ø)
...rt-controls/src/shared-controls/sharedControls.tsx 53.44% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...i-chart-controls/src/utils/expandControlConfig.tsx 100.00% <ø> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)
superset/views/core.py 75.43% <0.00%> (+0.45%) ⬆️
superset/models/core.py 90.50% <0.00%> (+0.69%) ⬆️
superset/db_engine_specs/mysql.py 98.80% <0.00%> (+4.76%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro
Copy link
Member

Thanks for this @maleksan ! Could you add a screenshot to the description showing the map in action?

@maleksan
Copy link
Contributor Author

Thanks for this @maleksan ! Could you add a screenshot to the description showing the map in action?

Added. Please add this new LV map into the next release.

@villebro
Copy link
Member

Thanks for this @maleksan ! Could you add a screenshot to the description showing the map in action?

Added. Please add this new LV map into the next release.

Hi, I mostly meant showing a screenshot of the new map in Superset, not the notebook. Also, if you don't mind, please add the notebook changes to this PR so it's up to date.

@maleksan
Copy link
Contributor Author

Thanks for this @maleksan ! Could you add a screenshot to the description showing the map in action?

Added. Please add this new LV map into the next release.

Hi, I mostly meant showing a screenshot of the new map in Superset, not the notebook. Also, if you don't mind, please add the notebook changes to this PR so it's up to date.

  • Sorry, there will be no opportunity to make a build to demonstrate this to you in the near future.
  • Notebook changes added.

@villebro
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@villebro Ephemeral environment spinning up at http://54.203.72.96:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@villebro
Copy link
Member

  • Sorry, there will be no opportunity to make a build to demonstrate this to you in the near future.
  • Notebook changes added.

@maleksan I spun up test env and verified that the chart works as expected and added a screenshot to the description.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! 🇱🇻

@villebro villebro merged commit 9578a44 into apache:master Nov 25, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@maleksan
Copy link
Contributor Author

@villebro,
is it possible to add this feature into the nearest Superset release?

@villebro
Copy link
Member

@maleksan I believe this is included in the current 2.1.0 release candidate that's up for vote

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants