-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Empty Error Alert Modal #22186
fix: Empty Error Alert Modal #22186
Conversation
@zhaoyongjie I know that you have worked on this component before, interested in hearing your thoughts on the matter. |
Codecov Report
@@ Coverage Diff @@
## master #22186 +/- ##
=======================================
Coverage 67.00% 67.00%
=======================================
Files 1835 1835
Lines 69971 69971
Branches 7590 7590
=======================================
Hits 46881 46881
Misses 21124 21124
Partials 1966 1966
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/testenv up |
@lyndsiWilliams Ephemeral environment spinning up at http://35.86.94.215:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simple fix!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
The Error Alert in the database modal was showing users a "See More" link that was displaying an empty modal.
Looking into this issue, there seemed to be a disconnect between a description and a body. With a body being the additional information that we want to display to a user should it not all fit in the original Error Alert. This PR adds a conditional to the Error Alert that checks for a body to be present in order to show the "See More" text.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
![image](https://user-images.githubusercontent.com/48933336/203171178-4b7b6a56-5418-46bc-acde-ce08f37ede77.png)
After:
Screen.Recording.2022-11-21.at.5.31.32.PM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION