-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dashboard api cache decorator #21964
fix: dashboard api cache decorator #21964
Conversation
Codecov Report
@@ Coverage Diff @@
## master #21964 +/- ##
==========================================
- Coverage 66.86% 65.54% -1.32%
==========================================
Files 1807 1807
Lines 69218 69218
Branches 7402 7402
==========================================
- Hits 46280 45370 -910
- Misses 21033 21943 +910
Partials 1905 1905
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Was there anything breaking in the original code? |
yes it was, further details on our pmc channel |
(cherry picked from commit c9470ca)
(cherry picked from commit c9470ca)
SUMMARY
Small refactor,
@etag_cache
needs to be on a different position on the decoratorsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION