-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Use slim image in Dockerfile #21326
chore: Use slim image in Dockerfile #21326
Conversation
Thanks for the PR. I would advise splitting this PR in two:
Finally to get started with deprecating 3.8, we would need to notify the mailing list about the upcoming deprecation well in advance (3-6 months ahead of happening). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment about npm version, other than that I think this is a great improvement 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would be interested in getting some other reviewers on this, as it's a pretty major change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the only concern is whether slim image lacks some system tools or third-part tools(e.g. wget), If users don't depend on system tools in a container, it will be a safe change.
@villebro @zhaoyongjie |
@EugeneTorap Thanks for a very useful change. Here is AWS ECR scan reports for comparison: Before change: After Change: IMO, Its a big improvement. Bumping python to 3.9 should further reduce vulnerabilities as most of the remaining critical and high vulnerabilities are Linux related. |
SUMMARY
Use slim image for python and nodeJS. Final slim python image will be 500 MB less.
Use slim image for modeJS no reduce downloading time.
Remove installing npm 7 because nodeJS 16 already has npm 8 which the same like npm 7
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION