Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Change text and icons in dashboard editmode #21305

Merged
merged 10 commits into from
Sep 30, 2022

Conversation

agl-developer
Copy link
Contributor

@agl-developer agl-developer commented Sep 2, 2022

SUMMARY

If user wants to add text to the dashboard, they have to go to "layout components" and choose "markdown". This is super not intuitive for users (findings from Sayya), especially as the icon is not related to the text.

  • Change 'Markdown' to 'Text' in edit mode sidebar
  • Change default text in markdown editor

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
Clipboard 2022-28-06 at 1 40 44 PM

After
image

TESTING INSTRUCTIONS

  • Click on Dashboards on the top left menu bar
  • Click on '+ Dashboard' on the top right button
  • Select 'Layout Elements' from the right sidebar
  • Drag 'Text' to the main editor

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

- Change 'Markdown' to 'Text' in edit mode sidebar
- Change default text in markdown editor
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #21305 (6a39113) into master (389fa31) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #21305   +/-   ##
=======================================
  Coverage   66.82%   66.82%           
=======================================
  Files        1798     1798           
  Lines       68824    68824           
  Branches     7331     7331           
=======================================
  Hits        45994    45994           
  Misses      20952    20952           
  Partials     1878     1878           
Flag Coverage Δ
javascript 53.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...oard/components/gridComponents/new/NewMarkdown.jsx 0.00% <ø> (ø)
...c/dashboard/components/gridComponents/Markdown.jsx 72.36% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agl-developer there's a Cypress test that needs fixing. I'll spin up a test env when that is fixed. Thanks!

@codyml
Copy link
Member

codyml commented Sep 28, 2022

@agl-developer Looks like another Cypress test is broken.

@geido
Copy link
Member

geido commented Sep 28, 2022

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://34.217.85.239:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido merged commit 1d70079 into apache:master Sep 30, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants