-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): Change text and icons in dashboard editmode #21305
Conversation
- Change 'Markdown' to 'Text' in edit mode sidebar - Change default text in markdown editor
Codecov Report
@@ Coverage Diff @@
## master #21305 +/- ##
=======================================
Coverage 66.82% 66.82%
=======================================
Files 1798 1798
Lines 68824 68824
Branches 7331 7331
=======================================
Hits 45994 45994
Misses 20952 20952
Partials 1878 1878
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agl-developer there's a Cypress test that needs fixing. I'll spin up a test env when that is fixed. Thanks!
@agl-developer Looks like another Cypress test is broken. |
/testenv up |
@geido Ephemeral environment spinning up at http://34.217.85.239:8080. Credentials are |
# Conflicts: # superset-frontend/cypress-base/cypress/integration/dashboard/editmode.test.ts
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
If user wants to add text to the dashboard, they have to go to "layout components" and choose "markdown". This is super not intuitive for users (findings from Sayya), especially as the icon is not related to the text.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
![Clipboard 2022-28-06 at 1 40 44 PM](https://user-images.githubusercontent.com/1985940/188050038-6ea47b49-380d-4f9d-92fd-627b3122357a.png)
After
![image](https://user-images.githubusercontent.com/1985940/188049115-dcc80e3f-65c7-4296-ba7f-2ec6289bded4.png)
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION