-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): Time column label not formatted when GENERIC_X_AXES enabled #21294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I believe I've fixed a few of these, so there may be more lurking in the shadows. If we bump into more of these we should perhaps consider refactoring this so we don't have to do these checks all over the place.
Yeah those just keep popping up. I know that recently @diegomedina248 fixed the same issue in other echarts |
Codecov Report
@@ Coverage Diff @@
## master #21294 +/- ##
==========================================
- Coverage 66.42% 66.40% -0.03%
==========================================
Files 1784 1784
Lines 68237 68237
Branches 7263 7264 +1
==========================================
- Hits 45328 45310 -18
- Misses 21040 21058 +18
Partials 1869 1869
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Yeah, that's right. |
…bled (apache#21294) (cherry picked from commit c3a00d4)
SUMMARY
When user has
GENERIC_CHART_AXES
enabled and adds a custom label to a time column, the timestamps on the chart's x axis are not formatted.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
GENERIC_CHART_AXES
ADDITIONAL INFORMATION