Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "Update Tab Name via config (#21116)" #21247

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Aug 30, 2022

This reverts commit 642a0d7.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

This reverts commit 642a0d7.
@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #21247 (cce3db0) into master (8772e2c) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21247      +/-   ##
==========================================
+ Coverage   66.43%   66.46%   +0.02%     
==========================================
  Files        1784     1784              
  Lines       68163    68162       -1     
  Branches     7264     7264              
==========================================
+ Hits        45285    45302      +17     
+ Misses      21010    20992      -18     
  Partials     1868     1868              
Flag Coverage Δ
hive 53.02% <ø> (-0.01%) ⬇️
javascript 52.49% <ø> (ø)
mysql 80.87% <ø> (?)
postgres 80.93% <ø> (+0.01%) ⬆️
presto 52.92% <ø> (-0.01%) ⬇️
python 81.40% <ø> (+0.05%) ⬆️
sqlite 79.44% <ø> (-0.01%) ⬇️
unit 50.65% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.58% <ø> (-0.03%) ⬇️
superset/reports/commands/execute.py 91.54% <0.00%> (+0.35%) ⬆️
superset/views/core.py 75.60% <0.00%> (+0.45%) ⬆️
superset/common/query_object.py 94.38% <0.00%> (+0.51%) ⬆️
superset/models/core.py 88.88% <0.00%> (+0.70%) ⬆️
superset/commands/importers/v1/utils.py 93.50% <0.00%> (+1.29%) ⬆️
superset/reports/commands/log_prune.py 89.28% <0.00%> (+3.57%) ⬆️
superset/db_engine_specs/mysql.py 98.80% <0.00%> (+4.76%) ⬆️
superset/common/utils/dataframe_utils.py 95.23% <0.00%> (+4.76%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AAfghahi AAfghahi changed the title Revert "Update Tab Name via config (#21116)" fix: Revert "Update Tab Name via config (#21116)" Aug 30, 2022
@hughhhh hughhhh merged commit f2d67f7 into master Aug 30, 2022
@mistercrunch mistercrunch deleted the revert-tab-name branch March 26, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants