fix(ViewQuery-Modal): Copy icon is out of box when resize query modal #21243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://35.89.85.65:8080. Credentials are |
Codecov Report
@@ Coverage Diff @@
## master #21243 +/- ##
=======================================
Coverage 66.43% 66.43%
=======================================
Files 1784 1784
Lines 68163 68169 +6
Branches 7264 7266 +2
=======================================
+ Hits 45285 45291 +6
+ Misses 21010 21009 -1
- Partials 1868 1869 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulo-eduardo
changed the title
stephenLYZ
reviewed
Aug 30, 2022
| @@ -289,6 +290,13 @@ const CustomModal = ({ | |||
| } | |||
| }; | |||
|
|
|||
| const getResizableConfig = () => { | |||
There was a problem hiding this comment.
It would be nice if we can use useMemo to reduce called.
There was a problem hiding this comment.
OHH, THAT IS RIGHT! Thank you 😊 working on it!
|
Ephemeral environment shutdown and build artifacts deleted. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding a fail safe to get default resize config when receive an empty object.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
Screen.Recording.2022-08-29.at.17.21.54.mov
AFTER
Screen.Recording.2022-08-29.at.17.21.18.mov
TESTING INSTRUCTIONS