-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ViewQuery-Modal): Copy icon is out of box when resize query modal #21243
Conversation
/testenv up |
@yousoph Ephemeral environment spinning up at http://35.89.85.65:8080. Credentials are |
Codecov Report
@@ Coverage Diff @@
## master #21243 +/- ##
=======================================
Coverage 66.43% 66.43%
=======================================
Files 1784 1784
Lines 68163 68169 +6
Branches 7264 7266 +2
=======================================
+ Hits 45285 45291 +6
+ Misses 21010 21009 -1
- Partials 1868 1869 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -289,6 +290,13 @@ const CustomModal = ({ | |||
} | |||
}; | |||
|
|||
const getResizableConfig = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we can use useMemo
to reduce called.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OHH, THAT IS RIGHT! Thank you 😊 working on it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix.
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Adding a fail safe to get default resize config when receive an empty object.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
Screen.Recording.2022-08-29.at.17.21.54.mov
AFTER
Screen.Recording.2022-08-29.at.17.21.18.mov
TESTING INSTRUCTIONS