Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forwardRef warnings in selects #20970

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes the following warning in selects:

Warning: forwardRef render functions do not support propTypes or defaultProps. 
Did you accidentally pass a React component?

No logic was changed. I just moved forwardRef as part of the const declaration before exporting it so the linter can understand the reference.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #20970 (0317bfa) into master (eb5369f) will increase coverage by 0.00%.
The diff coverage is 85.00%.

❗ Current head 0317bfa differs from pull request most recent head 440f80b. Consider uploading reports for the commit 440f80b to get more accurate results

@@           Coverage Diff           @@
##           master   #20970   +/-   ##
=======================================
  Coverage   66.38%   66.38%           
=======================================
  Files        1767     1767           
  Lines       67232    67235    +3     
  Branches     7138     7140    +2     
=======================================
+ Hits        44633    44636    +3     
  Misses      20773    20773           
  Partials     1826     1826           
Flag Coverage Δ
javascript 52.11% <85.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/components/Select/WindowedSelect/windowed.tsx 72.72% <80.00%> (+2.72%) ⬆️
...set-frontend/src/components/Select/AsyncSelect.tsx 83.26% <81.63%> (+0.07%) ⬆️
superset-frontend/src/components/Select/Select.tsx 87.16% <90.75%> (+0.08%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Michael. Thanks for the improvement. LGTM!

@michael-s-molina michael-s-molina merged commit 6650076 into apache:master Aug 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants