Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumps the handlebars plugin package version to match the family. #20813

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

rusackas
Copy link
Member

SUMMARY

Just bumps the version number to be in lockstep with other plugins. Will publish to NPM once this merges.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #20813 (9fff1a0) into master (5317462) will decrease coverage by 0.02%.
The diff coverage is 69.41%.

❗ Current head 9fff1a0 differs from pull request most recent head 8016747. Consider uploading reports for the commit 8016747 to get more accurate results

@@            Coverage Diff             @@
##           master   #20813      +/-   ##
==========================================
- Coverage   66.85%   66.83%   -0.03%     
==========================================
  Files        1753     1755       +2     
  Lines       65833    65995     +162     
  Branches     7007     7056      +49     
==========================================
+ Hits        44011    44105      +94     
- Misses      20036    20092      +56     
- Partials     1786     1798      +12     
Flag Coverage Δ
javascript 51.98% <55.97%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...et-ui-chart-controls/src/shared-controls/index.tsx 51.26% <0.00%> (ø)
...ackages/superset-ui-core/src/query/types/Column.ts 100.00% <ø> (ø)
...packages/superset-ui-core/src/query/types/Query.ts 100.00% <ø> (ø)
...s/legacy-plugin-chart-heatmap/src/controlPanel.tsx 57.14% <ø> (ø)
...ns/legacy-preset-chart-deckgl/src/utils/explore.js 0.00% <0.00%> (ø)
...set-chart-nvd3/src/vendor/superset/exploreUtils.js 0.00% <0.00%> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 55.95% <ø> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 50.00% <ø> (ø)
...plugin-chart-echarts/src/Treemap/transformProps.ts 51.51% <ø> (ø)
... and 156 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@zhaoyongjie zhaoyongjie merged commit fe9eb58 into master Jul 22, 2022
@michael-s-molina
Copy link
Member

master is failing again after this PR 😢. Can you check @rusackas?

@rusackas
Copy link
Member Author

Now it's published on NPM, so hopefully that resolves it... again. Gotta find some automated way to bump versions and publish. The github bot might be one good way to do that... e.g. watch for a merge, and publish automatically... or something a similar action based on tags.

@rusackas
Copy link
Member Author

Actually, CI seems to be TRYING to publish the package... not sure if GH Actions can use a specific bot-username that we give proper permissions to on NPM.

@rusackas rusackas deleted the bumping-handlebars-plugin-version branch July 22, 2022 15:14
@mistercrunch mistercrunch added 🚢 2.1.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants