-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Redirects old Explore URLs to the new ones #20812
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20812 +/- ##
==========================================
- Coverage 66.29% 66.12% -0.18%
==========================================
Files 1758 1758
Lines 66801 66803 +2
Branches 7055 7055
==========================================
- Hits 44288 44173 -115
- Misses 20713 20830 +117
Partials 1800 1800
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you!
(cherry picked from commit 34278c2)
🏷️ preset:2022.29 |
SUMMARY
To preserve bookmarked URLs this PR redirects old Explore URLs in the format
/superset/explore
to the new one without the/superset
prefix. This only affectsGET
operations. We only preserved thePOST
operation in case anyone is using it for something. In any case, this endpoint will be deleted in 3.0 as the warning clearly states.Follow-up of #20572
TESTING INSTRUCTIONS
Check if old Explore URLs are redirected to the new ones with all parameters preserved.
ADDITIONAL INFORMATION