Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Audit E2E tests for color schemes in Dashboard and Explore #20807

Merged
merged 13 commits into from
Aug 9, 2022

Conversation

geido
Copy link
Member

@geido geido commented Jul 21, 2022

SUMMARY

Enhanced the Cypress tests for the color schemes to:

  • Test the selection of a color scheme for a Dashboard when saving and editing
  • Test the color schemes are applied
  • Test the selection of a color scheme for viz types

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #20807 (ac03654) into master (802b69f) will decrease coverage by 11.49%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master   #20807       +/-   ##
===========================================
- Coverage   66.35%   54.85%   -11.50%     
===========================================
  Files        1767     1767               
  Lines       67332    67332               
  Branches     7144     7144               
===========================================
- Hits        44675    36934     -7741     
- Misses      20829    28570     +7741     
  Partials     1828     1828               
Flag Coverage Δ
hive 53.13% <ø> (ø)
javascript 52.11% <ø> (ø)
mysql ?
postgres ?
presto 53.03% <ø> (ø)
python 57.76% <ø> (-23.72%) ⬇️
sqlite ?
unit 50.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-88.89%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/create.py 29.41% <0.00%> (-68.63%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-67.45%) ⬇️
superset/views/datasource/utils.py 26.66% <0.00%> (-66.67%) ⬇️
superset/reports/commands/execute.py 25.37% <0.00%> (-66.05%) ⬇️
... and 278 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 22, 2022
Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geido geido merged commit 03764e6 into master Aug 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the chore/color-scheme-tests branch March 26, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants