Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: core coverage and add a coverage step in workflow #20784

Merged
merged 2 commits into from
Jul 20, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

bring 100% code coverage to the superset-ui/core. this PR should wait for this to merge.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@@ -53,7 +53,4 @@ export const DEFAULT_METRICS: Metric[] = [
},
];

export const isValidDatasourceType = (datasource: DatasourceType) =>
Copy link
Member Author

@zhaoyongjie zhaoyongjie Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function is unused, a more readable expression is 'Table' in DatasourceType.

@zhaoyongjie zhaoyongjie changed the title fix: core coverage fix: core coverage and add a coverage step in workflow Jul 20, 2022
@michael-s-molina michael-s-molina self-requested a review July 20, 2022 10:36
@codecov
Copy link

codecov bot commented Jul 20, 2022

Codecov Report

Merging #20784 (329fe5a) into master (bb5b8e4) will decrease coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 329fe5a differs from pull request most recent head 8387448. Consider uploading reports for the commit 8387448 to get more accurate results

@@            Coverage Diff             @@
##           master   #20784      +/-   ##
==========================================
- Coverage   66.30%   66.25%   -0.06%     
==========================================
  Files        1756     1756              
  Lines       66737    66735       -2     
  Branches     7049     7049              
==========================================
- Hits        44251    44216      -35     
- Misses      20689    20723      +34     
+ Partials     1797     1796       -1     
Flag Coverage Δ
javascript 51.93% <ø> (+<0.01%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/superset-ui-core/src/query/types/Datasource.ts 100.00% <ø> (+33.33%) ⬆️
...et-frontend/src/dashboard/actions/sliceEntities.js 74.28% <ø> (ø)
superset/db_engine_specs/presto.py 84.26% <0.00%> (-4.77%) ⬇️
superset/connectors/sqla/models.py 89.36% <0.00%> (-0.97%) ⬇️
superset/models/core.py 88.43% <0.00%> (-0.25%) ⬇️
...ckages/superset-ui-core/src/query/DatasourceKey.ts 100.00% <0.00%> (+16.66%) ⬆️

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 9c7bcfc into apache:master Jul 20, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants