-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: core coverage and add a coverage step in workflow #20784
fix: core coverage and add a coverage step in workflow #20784
Conversation
@@ -53,7 +53,4 @@ export const DEFAULT_METRICS: Metric[] = [ | |||
}, | |||
]; | |||
|
|||
export const isValidDatasourceType = (datasource: DatasourceType) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is unused, a more readable expression is 'Table' in DatasourceType
.
e200041
to
8387448
Compare
Codecov Report
@@ Coverage Diff @@
## master #20784 +/- ##
==========================================
- Coverage 66.30% 66.25% -0.06%
==========================================
Files 1756 1756
Lines 66737 66735 -2
Branches 7049 7049
==========================================
- Hits 44251 44216 -35
- Misses 20689 20723 +34
+ Partials 1797 1796 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SUMMARY
bring 100% code coverage to the
superset-ui/core
. this PR should wait for this to merge.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION