Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): Scrollbar after removing an annotation #20720

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

ControlPopover is in charge of handling the scroll status, however, after we remove an annotation, its ControlPopover is not longer available thus the scroll status stays hidden. We need reset it to be auto so the scroll bar shows

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
error

After:
test

TESTING INSTRUCTIONS

  1. open mix-time series chart in explore
  2. add annotation
  3. remove annotation
  4. Expected results: Scrollbar is still showing in the control panel section after you remove the annotation

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

- Fix scrollbar when removing annotations
@codecov
Copy link

codecov bot commented Jul 15, 2022

Codecov Report

Merging #20720 (53fe0a7) into master (a6abcd9) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master   #20720      +/-   ##
==========================================
- Coverage   66.84%   66.84%   -0.01%     
==========================================
  Files        1750     1750              
  Lines       65896    65899       +3     
  Branches     7017     7018       +1     
==========================================
  Hits        44048    44048              
- Misses      20062    20065       +3     
  Partials     1786     1786              
Flag Coverage Δ
javascript 51.93% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/controls/AnnotationLayerControl/index.jsx 9.67% <0.00%> (-0.50%) ⬇️
...ponents/controls/ControlPopover/ControlPopover.tsx 89.09% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6abcd9...53fe0a7. Read the comment docs.

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://35.85.30.104:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit e2206a7 into apache:master Aug 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2022

Ephemeral environment shutdown and build artifacts deleted.

@Antonio-RiveroMartnez Antonio-RiveroMartnez deleted the FIX-51076 branch August 2, 2022 21:15
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants