-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: logger message #20714
fix: logger message #20714
Conversation
Codecov Report
@@ Coverage Diff @@
## master #20714 +/- ##
===========================================
- Coverage 66.82% 55.19% -11.64%
===========================================
Files 1750 1750
Lines 65896 65896
Branches 7017 7017
===========================================
- Hits 44035 36370 -7665
- Misses 20075 27740 +7665
Partials 1786 1786
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@betodealmeida The license error was fixed here so you just need to rebase your PR. |
(cherry picked from commit c70d102)
(cherry picked from commit c70d102)
SUMMARY
Small fix: when we try to load a DB engine spec but it fails (because of missing dependencies, for example) the logging message will also fail because
engine_spec
is undefined.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION