chore: Remove unecessary code from async and sync select components

[cccs-RyanK]

SUMMARY

This task was outlined as a part of this PR by @michael-s-molina : #20143

In a previous PR, the code for Select and AsyncSelect was split into two separate components: #20466
The components were left identical, so this PR continues the work and removes the unecessary code that was left in each of the components. Namely, it removes behaviour that had previously been determined by whether the component was in async mode or not.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[michael-s-molina]

Thank you for the PR @cccs-RyanK! I left some first-pass comments about the sync version. I'll review the async version later 😉

[michael-s-molina]

@cccs-RyanK About your question on Slack... I think it's a good idea to clean the components first and extract shared behaviors in another PR. It will be easier to check what can be extracted after the cleanup and it will be easier to review the changes.

[michael-s-molina]

@cccs-RyanK Thank you for the test improvements!

[codecov]

Codecov Report

Merging #20690 (eb04cbb) into master (922b4b8) will decrease coverage by 0.03%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master   #20690      +/-   ##
==========================================
- Coverage   66.29%   66.26%   -0.04%     
==========================================
  Files        1758     1758              
  Lines       66801    66930     +129     
  Branches     7055     7088      +33     
==========================================
+ Hits        44288    44349      +61     
- Misses      20713    20770      +57     
- Partials     1800     1811      +11     

Flag	Coverage Δ
javascript	51.94% <77.77%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...frontend/src/components/DatabaseSelector/index.tsx	88.88% <ø> (ø)
...et-frontend/src/components/TableSelector/index.tsx	76.08% <ø> (ø)
...t-frontend/src/filters/components/GroupBy/types.ts	100.00% <ø> (ø)
...rontend/src/filters/components/TimeColumn/types.ts	100.00% <ø> (ø)
...frontend/src/filters/components/TimeGrain/types.ts	100.00% <ø> (ø)
...rontend/src/components/ListView/Filters/Select.tsx	52.38% <33.33%> (-2.62%)	⬇️
...set-frontend/src/components/Select/AsyncSelect.tsx	83.18% <80.00%> (+0.34%)	⬆️
superset-frontend/src/components/Select/Select.tsx	87.07% <100.00%> (+19.29%)	⬆️
...components/DashboardBuilder/DashboardContainer.tsx	40.00% <0.00%> (-32.23%)	⬇️
...nd/src/dashboard/util/activeAllDashboardFilters.ts	60.00% <0.00%> (-26.96%)	⬇️
... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

[michael-s-molina]

Although showSearch is true by default, it can be disabled.

[michael-s-molina]

LGTM. Thank you for all the hard work @cccs-RyanK!